feat: add metadata signature check #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added metadata signature check when verifying the revealed value proofs, just to be sure that the basis of the balance calculation check will have integrity.
|
This supersedes #5412, which merely adds scary warning comments about verification. |
ghpbot-tari-project
added
P-acks_required
AaronFeickert
requested changes
May 25, 2023
base_layer/core/src/transactions/transaction_components/transaction_output.rs
Outdated
Show resolved
Hide resolved
| assert!(output.verify_metadata_signature().is_ok()); | ||
| assert!(output.revealed_value_range_proof_check().is_ok()); | ||
|
|
||
| output.features.maturity += 1; |
There was a problem hiding this comment.
Can this overflow and fail the test? I know we've seen this elsewhere in tests.
There was a problem hiding this comment.
For the test, it does not matter if it overflows, as long as it is changed, so that the features committed to in the metadata signature is different.
There was a problem hiding this comment.
Right, I had been concerned that an overflow could panic and intermittently fail the test, depending on how the value was originally set. Looks like it's originally set to zero, so this can't happen. I'd do output.features.maturity = 1 instead anyway; seems more elegant!
4 tasks
SWvheerden
added a commit
that referenced
this pull request
May 29, 2023
## [0.50.0-pre.2](v0.50.0-pre.1...v0.50.0-pre.2) (2023-05-29) ### ⚠ BREAKING CHANGES * add optional range proof types (5372) ### Features * add metadata signature check ([5411](#5411)) ([9c2bf41](9c2bf41)) * add optional range proof types ([5372](#5372)) ([f24784f](f24784f)) * added burn feature to the console wallet ([5322](#5322)) ([45685b9](45685b9)) * improved base node monitoring ([5390](#5390)) ([c704890](c704890)) ### Bug Fixes * **comms:** only set final forward address if configured to port 0 ([5406](#5406)) ([ff7fb6d](ff7fb6d)) * deeplink to rfc spec ([5342](#5342)) ([806d3b8](806d3b8)) * don't use in memory datastores for chat client dht in integration tests ([#5399](#5399)) ([cbdca6f](cbdca6f)) * fix panic when no public addresses ([5367](#5367)) ([49be2a2](49be2a2)) * loop on mismatched passphrase entry ([5396](#5396)) ([ed120b2](ed120b2)) * use domain separation for wallet message signing ([5400](#5400)) ([7d71f8b](7d71f8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added metadata signature check when verifying the revealed value proofs, just to be sure that the basis of the balance calculation check will have integrity.
Motivation and Context
See above.
How Has This Been Tested?
Added a new unit test.
What process can a PR reviewer use to test or verify this change?
Inspection
Breaking Changes